New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ts-ignore todos #1

Merged

dimitropoulos merged 1 commit into dimitropoulos:ts-comment-allow-with-description from chandlerprall:ts-comment-allow-with-description

Jun 10, 2020

chandlerprall commented Jun 10, 2020

Cleans up those TS todos. I also fixed a function name typo in a test file.


          Clean up ts-ignore todos

chandlerprall mentioned this pull request

Lint rule for requiring ts-ignore descriptions elastic/eui#3584

Merged

1 task

dimitropoulos reviewed

View reviewed changes

src/components/date_picker/super_date_picker/async_interval.test.ts

@@ @@ -32,16 +32,13 @@ describe('AsyncInterval', () => { @@
                 // Advances time and awaits any pending promises after every 100ms
                 // This helper makes it easier to advance time without worrying
                 // whether tasks are still lingering on the event loop
-                async function andvanceTimerAndAwaitFn(
+                async function advanceTimerAndAwaitFn(

Owner

dimitropoulos Jun 10, 2020

good eye, good eye.

dimitropoulos merged commit 2464d49 into dimitropoulos:ts-comment-allow-with-description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment