Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript] insomnia-cookies #5

Closed
wants to merge 1 commit into from
Closed

Conversation

dimitropoulos
Copy link
Owner

No description provided.

@dimitropoulos
Copy link
Owner Author

although making separate branches is much nicer for GitHub/review purposes, only those packages that have no other dependencies from the project will work since they consume each others' types. For example, insomnia-inso consumes types from insomnia-testing. If I pull those changes out, it will error because it's expecting types. For that reason I've pushed a branch ts/first7 that contains all of these exact same commits, but stacked. If you want to run something, your best bet will be to do so from there. I'll then make sure that everything is always symmetrical between the two.

insomnia-cookies
Copy link

@DMarby DMarby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

packages/insomnia-cookies/package.json Show resolved Hide resolved
packages/insomnia-cookies/src/cookies.ts Show resolved Hide resolved
@dimitropoulos
Copy link
Owner Author

after feedback (and all fixex therein) and/or approval this PR is closing because this branch is now being incorporated into the dimitropoulos/typescript branch. this isn't final, there is another round of review happening when dimitropoulos/typescript is PR'd into Kong/develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants