gate the stable_hash test to only run on little endinan machines #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Double-checked that the test is still run on CI so this seems fine to me. Will you be able to confirm this fix after it merges? |
|
Let me track down a machine to test this on before merging, I'll report back. |
|
The change makes sense to me so I don't mind merging first if that's at all easier; I just want to be able to validate the issue is resolved at some point 🙂 |
dimo414
reviewed
Nov 5, 2023
|
@alexanderkjall still interested in merging this? |
|
yes please, I didn't manage to scare up a test machine and are currently very short on free time :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #39 (I hope, lacking a test machine to verify on)