Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Attempt to add aarch64 osx build to CI #52

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

kumy
Copy link
Contributor

@kumy kumy commented May 11, 2024

Add target aarch64-apple-darwin as done in sharkdp/fd#1552

Fix: #17
馃

Add  target `aarch64-apple-darwin` as done in sharkdp/fd#1552
@kumy kumy mentioned this pull request May 11, 2024
Copy link
Owner

@dimo414 dimo414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! It looks like it works on my mac (after I ran xattr -d com.apple.quarantine ... as suggested here). You can grab it from the CI job here if you'd like to confirm as well. I'm assuming the need to bypass the quarantine is expected given that the binary isn't signed or anything like that.

@kumy
Copy link
Contributor Author

kumy commented May 11, 2024

Thanks. I don't own such hardware. I will ask my colleague on Monday to test it if/when he can :)

@dimo414
Copy link
Owner

dimo414 commented May 12, 2024

Don't worry about it, thanks for the PR!

@dimo414 dimo414 merged commit 33c789c into dimo414:master May 12, 2024
10 checks passed
@kumy kumy deleted the patch-2 branch May 12, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide arm64 Darwin build
2 participants