This repository has been archived by the owner on Jun 18, 2019. It is now read-only.
Added notTranslatedIn scopes #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public function test_not_translated_in_scope_returns_only_not_translated_records_for_this_locale() | ||
| { | ||
| $notTranslatedCountries = Country::notTranslatedIn('en')->get(); | ||
|
|
There was a problem hiding this comment.
This is really great! Can you please assert here that count(notTranslatedCountries) is positive?
Added test
|
@dimsav - I added two checks for counting the objects and I squashed the new commits into one. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a scope (
notTranslatedIn) for fetching by those who doesn't have a specific translation.Useful for creating a view to translate content and filtering by missing translations.