This repository has been archived by the owner on Jun 18, 2019. It is now read-only.
Fix issue when trying to fetch a translation with a country based locale #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g. 'pt-PT') and the only translation available is for the fallback locale. Cover the scenario where the configured fallback locale is 'en', you are trying to fetch a translation for 'pt-PT' but the model only have a translation to 'en'. As it was before the code would attempt to fetch a translation for 'pt' twice instead of trying 'pt' first and then the configured fallback locale.
|
Hi @vcarreira and thanks for your contribution! Can you please write a test that your change fixes? |
|
Hi @dimsav I added the requested test and thanks for this amazing package. Glad to be able to make a very small contribution. |
|
Awesome work, thanks a bunch! |
|
Fix was released in v6.0.1! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue when trying to fetch a translation with a country based (e.g. 'pt-PT') and the only translation available is for the fallback locale.
Cover the scenario where the configured fallback locale is 'en', you are trying to fetch a translation for 'pt-PT' but the model only has a translation to 'en'. As it was before the code would attempt to fetch a translation for 'pt' twice instead of trying 'pt' first and then use the configured fallback locale.