This repository has been archived by the owner on Jun 18, 2019. It is now read-only.
Locale fallback mode can be set per model #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kevinwwilson and thanks for your commits. Could you please send those pull requests to the development branch? Sorry for the long delay, I was in summer vacations :) |
|
I just did it for you. See here. I also added the possibility to override the default fallback even when the model's fallback is false. Cheers! |
|
Very nice. Many thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was very happy to find this package!
As I started using it, I realized that I wanted a better way to default whether or not the fallback would be used rather than having to specify to use it every time I accessed the data. This change would allow the model to decide whether or not to use the fallback mode.