Skip to content
This repository has been archived by the owner. It is now read-only.

Implement fallback option in case attribute returns empty value #348

Merged
merged 3 commits into from Jun 6, 2017

Conversation

@k-zakhariy
Copy link
Contributor

commented May 14, 2017

With this option we can have ability to get fallback value from fallback language in case
target language exists but attribute value is empty

@unitedworx

This comment has been minimized.

Copy link
Contributor

commented May 22, 2017

Would be nice if this is added in!

Solves a problem when some fields are translated and some are not and you end up with the website missing texts!

@dimsav

This comment has been minimized.

Copy link
Owner

commented May 25, 2017

I like the idea. We still need to update the docs, the configuration and write the tests in order to merge this.

@unitedworx

This comment has been minimized.

Copy link
Contributor

commented May 25, 2017

@k-zakhariy it will be superb if you have time to amend the docs, configuration and tests for this pull request to be accepted by dimsav.

@k-zakhariy

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2017

will push changes soon

@k-zakhariy

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2017

Any updates on this ?

@dimsav

This comment has been minimized.

Copy link
Owner

commented Jun 5, 2017

Thanks a lot for your work. Will try to review this week.

@dimsav

This comment has been minimized.

Copy link
Owner

commented Jun 6, 2017

@k-zakhariy @unitedworx I was thinking to leave out the per-model config. Do you guys have a use case in mind where you plan to have different per model configuration?

@dimsav dimsav merged commit 84cbc1f into dimsav:master Jun 6, 2017

1 check passed

continuous-integration/styleci/pr The StyleCI analysis has passed
Details
@k-zakhariy

This comment has been minimized.

Copy link
Contributor Author

commented Jun 6, 2017

@dimsav I didn't use this ability in my project, for me its easy to declare options in config file.
I guess you need to think if this feature (per-model config) can be useful for some cases, in new projects

@unitedworx

This comment has been minimized.

Copy link
Contributor

commented Jun 8, 2017

i will surely follow a project wide route, if you start having models behaving differently it might be confusing down the line.

@dimsav

This comment has been minimized.

Copy link
Owner

commented Jun 8, 2017

True, that's why I removed the per model config.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.