This repository has been archived by the owner on Jun 18, 2019. It is now read-only.
Fix withTranslation query scope performance issues and fallback for country-based locales #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests were failing because the return array also contained an unexpected 'translations' key.
When using the `withTranslation` query scope along with country-based locales, the generated query didn't include the country fallback (e.g. `de-DE` should first fall back to `de` before using the fallback defined in the configuration). Also fix dimsav#241 by generating a WHERE IN clause instead chaining AND/ORs
raphaelsaunier
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two separate but related issues with the
withTranslationquery scope.Slow performance due to over-fetching
As reported in #241, the generated SQL has an error that will cause it to incorrectly fetch all of the translations for the default language:
This can be fixed by wrapping the
ORclauses in parentheses (by using the adequate query builder methods), or simply by using aWHERE INstatement. I chose the latter option.Language fallback is skipped when using a country-based locale
When using country-based fallbacks, the language fallback wasn't appended to the SQL request. So, to build on the current example scenario in the README, instead of querying for
es-MX,es,en, the query only looked fores-MXanden, and skipping the language altogether.Also, since this feature didn't seem to have any tests, I have added started adding a few.