Skip to content
This repository has been archived by the owner. It is now read-only.

use fallback in attributesToArray #503

Merged
merged 6 commits into from Jul 24, 2018

Conversation

@Gummibeer
Copy link
Collaborator

commented Jul 24, 2018

replaces: #466 by @Gummibeer
solves:

Gummibeer added some commits May 14, 2018

Merge pull request #466 from Gummibeer/patch-7
use fallback in attributesToArray

@Gummibeer Gummibeer self-assigned this Jul 24, 2018

@Gummibeer

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 24, 2018

1) TestCoreModelExtension::test_to_array_wont_break_if_no_translations_exist

ErrorException: Trying to get property of non-object
/home/circleci/project/src/Translatable/Translatable.php:164
/home/circleci/project/src/Translatable/Translatable.php:698
/home/circleci/project/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php:1038
/home/circleci/project/tests/TestCoreModelExtension.php:163

@Gummibeer Gummibeer added the todo label Jul 24, 2018

Gummibeer added some commits Jul 24, 2018

@Gummibeer Gummibeer added next release and removed todo labels Jul 24, 2018

@dimsav dimsav merged commit 476e0ea into master Jul 24, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details

@dimsav dimsav deleted the pr-466 branch Jul 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.