Replace innerHTML to preserve Trusted Types

see #1947 Co-Authored-By: Klára Petrovičová <109086288+klarapetrovicova@users.noreply.github.com>
dimsemenov · Jul 22, 2022 · ddcad46 · ddcad46
1 parent 9a39c55
commit ddcad46
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/js/slide/content.js b/src/js/slide/content.js
@@ -349,7 +349,7 @@ class Content {
       );
       this.element = createElement('pswp__content pswp__error-msg-container');
       this.element.appendChild(errorMsgEl);
-      this.slide.container.innerHTML = '';
+      this.slide.container.innerText = '';
       this.slide.container.appendChild(this.element);
       this.slide.updateContentSize(true);
       this.removePlaceholder();

diff --git a/src/js/slide/slide.js b/src/js/slide/slide.js
@@ -106,7 +106,6 @@ class Slide {
 
     // Slide appended to DOM
     if (!this.data) {
-      this.holderElement.innerHTML = '';
       return;
     }
 
@@ -211,6 +210,7 @@ class Slide {
   destroy() {
     this.content.hasSlide = false;
     this.content.remove();
+    this.container.remove();
     this.pswp.dispatch('slideDestroy', { slide: this });
   }