-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V5-Beta Is attribute data-cropped="true" correctly working? #1781
Comments
The aspect ratio of thumbnail image itself must match the large image, you crop it via CSS (either via |
Well I don’t think my thumbnails are cropped via CSS, it is done with a JAVA ConstrainRatioFilter, so that explains why ir does not work. Thanks for your quick response! |
You can see cropped thumbnails on my gallery, thumbnails are cropped with this kind of CSS: .gallery {
display: flex;
flex-wrap: wrap;
}
.gallery:after {
content: '';
flex-grow: 5;
}
.thumb {
margin: 2px;
flex-grow: 1;
max-height: 250px;
overflow: hidden;
}
.thumb > img {
height: 100%;
width: 100%;
object-fit: cover;
} With the scheme: <div class="gallery">
<a class="thumb" ... >
<img ... >
</a>
<a class="thumb" ... >
<img ... >
</a>
<a class="thumb" ... >
<img ... >
</a>
</div> My |
Thanks @BilouMaster for this hints, this will help me a lot to solve this! |
Well if I open your nice gallery on my Windows 10 PC I see indeed a zoomed animation effect. |
If I use this CSS and HTML code:
it works OK on my PC see https://www.andrewolff.nl/Test_Photopswipe_V5/PSP5-coverPano/ but on my iPad I see no zoom effect. |
This album containes fixed-size thumbnails which are all cropped., so I added attribute data-cropped="true" to all thumbnails like the 7th panoramic image:
I don't think that the addition lof this attribute eads to a smoothly zoom-out transition, try-it-yourself.
Do I something wrongly?
Or is the difference in aspect ratio too extreme?
This album has been made with the same images but now with a thumbnails page made with the Justified Gallery, only images 6 and 7 are cropped and do have the data-cropped="true" attribute, but I am not impressed by the results off this added attribute.
The text was updated successfully, but these errors were encountered: