Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define an alt text for images for accessibility reasons #1423

Closed
wants to merge 2 commits into from

Conversation

shofer
Copy link

@shofer shofer commented Sep 20, 2017

For legal and accessibility reasons we have to provide an alt text for each image served by our website. Even it could be necessary to define an empty alt text to indicate that this image has no additional meaning.

More about alt text for web accessibility could be found here:
http://webaccess.its.uiowa.edu/workshops/alt/index.html
http://webaccess.its.uiowa.edu/workshops/alt/alt006.html

@shofer shofer force-pushed the set-image-alt-text-src branch 2 times, most recently from 797f15c to c3d54a6 Compare September 22, 2017 07:07
@shofer
Copy link
Author

shofer commented May 27, 2019

@jonathanmeurrens is there a possibility that this change gets into master? - we still have to use the forked version, just because of this small change
thanks

@jonathanmeurrens
Copy link

@shofer For me it's ok to merge to master. But as this is not my repository/project, I'd ask that question to @dimsemenov.

@clottman
Copy link

@shofer do you have a built version (updated files in dist/) that you can push? I was trying to use your fork, and wondering why it was broken until I realized you hadn't updated the dist/ files.

@shofer
Copy link
Author

shofer commented Jul 24, 2019

@clottman its a seperate branch because the build should not be merged
https://github.com/shofer/PhotoSwipe/tree/set-image-alt-text

@clottman
Copy link

@shofer wonderful, thank you so much! I couldn't get npm install and grunt to work successfully when I tried building from your source.

@dgiraldo313
Copy link

Any update on this? It would be great to have the ability to add alt text to the images.

@shofer
Copy link
Author

shofer commented Feb 21, 2020

@dimsemenov do you see any chances to get this change into master?

@dimsemenov
Copy link
Owner

Fixed in v5.

@dimsemenov dimsemenov closed this Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants