fix: errorMsg may cause XSS attack #1747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PhotoSwipe does not sanitize the content, not for images, not for the caption. Escape the URLs before passing them to PhotoSwipe. This is also partly fixed in v5 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, guy, I found a bug which will cause XSS attack, in
errorMSg, you useinnerHTMLto replace%url, but origin image src url maybe an unsafe url, like thishttps://example.com/"/>"<script>alert("1")</script>"<a. So, must escape origin image url, replace<>'or".This bug not only in default error message, but also in custom error.
