-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for image title from alt attribute #1766
Conversation
I'm going to add a visibility check for the counter indicator, otherwise the title overlaps on the left when there are multiple images... |
I don't really want to include a caption module into the core, as it's very hard to create a versatile solution - some captions are long, some captions have links, some captions need to be scrollable etc. You may create a separate repository with just a caption module, and I'll link to it. Or this pull request itself will help someone for sure.
|
No worries at all @dimsemenov, I just thought that quite a few people would find this useful; I definitely see where we could encounter some problems with making the caption implementation versatile. I'll continuing improving this; the caption div currently has an ellipsis text overflow, and I can test this more to ensure that different caption lengths are displayed properly :) |
@dimsemenov When you think you'll release it? @brunogrcsada If caption is a long term implementation, you could make a separated PR just for the Warning issue? 4944ac8 Thanks |
I don't agree with this statement, most people do find it useful, |
Hi, everybody. The |
There's caption plugin now https://github.com/dimsemenov/photoswipe-dynamic-caption-plugin Feel free to fork or create a simpler version. |
When can I expect an update of the caption plugin? |
@acwolff for now the only caption plugin that I maintain is https://github.com/dimsemenov/photoswipe-dynamic-caption-plugin , I might make another one, a much simpler one (based on the Caption section of docs). |
Yes, that is the caption I am using (see https://andrewolff.jalbum.net/PS_Samples_AA/). |
Any text in an image's alt tag is taken and presented as the title...
Example: