Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set proper proxy theme #46

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Set proper proxy theme #46

merged 1 commit into from
Sep 12, 2020

Conversation

di72nn
Copy link
Contributor

@di72nn di72nn commented Jul 17, 2020

There's that annoying activity switching animation when sharing to Shaalier if it doesn't display dialog (so there's no activity to switch to). This proxy theme removes the animation.

This works fine (used in wallabag android app for a couple of years already) if the window is guaranteed not to display any UI, but may have side effects if the activity optionally shows UI. I tested the dialog mode only on Android 9 - it works ok, but the activity switching animation was different (probably because of windowIsTranslucent).
Maybe having a separate activity that never shows anything would work better.

I figured you should know about it, even so this is not a proper solution.

@dimtion dimtion self-assigned this Jul 20, 2020
@dimtion
Copy link
Owner

dimtion commented Jul 20, 2020

Thanks @di72nn great PR!

I've tried this out a bit, about the animation I don't have any strong stand on them, I did not work at all to have nice animations.

I'm not sure if you had the chance to test on a taller screen size, but tweaking a bit with you branch I had an issue at the the bottom of the screen where the underlying window would appear. This is a bit more worrisome than the animation, see the following screenshot:

Screenshot 2020-07-19 at 19 15 22

@di72nn
Copy link
Contributor Author

di72nn commented Jul 20, 2020

Yeah, that's problematic. I guess the only decent solution is to have one activity that never shows UI and delegate to another activity for UI.

@dimtion dimtion added this to the 1.8.0 milestone Aug 25, 2020
@dimtion dimtion merged commit a24831f into dimtion:master Sep 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants