Invisibility evaluate accurately #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinzid
force-pushed
the
master
branch
2 times, most recently
from
aff6163
to
6512f7d
Compare
|
Hi @vinzid Thanks for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the visibility of the lazy load element is determined base on weather the width or height of the element is 0, but if the placeholder image has not loaded, the width or height can be 0, so I bind the loadElement to the load event of the element to evaluate accurately after the placeholder image loaded.
This phenomenon is not frequent, but it deed happen periodically. So it's not easy to discover, but I think it should fixed for the stability of this plugin.