Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: api-extractor config #680

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

johnhooks
Copy link
Contributor

Update api-extractor.json after learning more about it.

  • use overrideTsconfig to eliminate the need for tsconfig.declaration.json files in the projects
  • add "newlineKind": "lf" to fix line ending issue

@vercel
Copy link

vercel bot commented Nov 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
dinerojs ✅ Ready (Inspect) Visit Preview Nov 27, 2022 at 5:30PM (UTC)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 27, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7936300:

Sandbox Source
@dinero.js/example-cart-react Configuration
@dinero.js/example-cart-vue Configuration
@dinero.js/example-starter Configuration

Update `api-extractor.json` after learning more about it.

- use `overrideTsconfig` to eliminate the need for `tsconfig.declaration.json` files in the projects
- add `"newlineKind": "lf"` to fix line ending issue
@@ -12,4 +11,5 @@
{ "path": "../currencies" }
],
"include": ["src"],
"exclude": [ "**/__tests__/**/*"]}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This formatting mistake in all the tsconfig.json files made it through my previous PR, sorry

Copy link
Collaborator

@sarahdayan sarahdayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarahdayan sarahdayan merged commit 185e9e8 into dinerojs:main Nov 29, 2022
@johnhooks johnhooks deleted the refactor/api-extractor-config branch November 29, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants