Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI tests: Python 3.9 style_check failure due to upstream issue #71

Closed
Dineshkarthik opened this issue Dec 30, 2020 · 2 comments · Fixed by #89
Closed

CI tests: Python 3.9 style_check failure due to upstream issue #71

Dineshkarthik opened this issue Dec 30, 2020 · 2 comments · Fixed by #89
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@Dineshkarthik
Copy link
Owner

Describe the bug
When including python 3.9 latest the CI pipeline faces failure this is due to an upstream issue with pylint - pylint-dev/pylint/issues/3882

Python Version
Python: 3.9

OS:
The OS and its version: OS independent

Logs

pylint media_downloader.py utils -r y
************* Module media_downloader
media_downloader.py:39: [E1136(unsubscriptable-object), _can_download] Value 'Optional' is unsubscriptable
media_downloader.py:86: [E1136(unsubscriptable-object), _get_media_meta] Value 'Optional' is unsubscriptable
media_downloader.py:105: [E1136(unsubscriptable-object), _get_media_meta] Value 'Optional' is unsubscriptable

Solution
Once pylint release a new version with support for python 3.9 use it.

@Dineshkarthik Dineshkarthik self-assigned this Dec 30, 2020
@Dineshkarthik Dineshkarthik added the dependencies Pull requests that update a dependency file label Dec 30, 2020
@stale
Copy link

stale bot commented Feb 13, 2021

This issue has been automatically marked as stale because it has not had recent activity in the past 60 days. It will be closed if no further activity occurs in the next 7 days. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 13, 2021
@Dineshkarthik Dineshkarthik removed the wontfix This will not be worked on label Feb 13, 2021
@stale
Copy link

stale bot commented Mar 30, 2021

This issue has been automatically marked as stale because it has not had recent activity in the past 60 days. It will be closed if no further activity occurs in the next 7 days. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 30, 2021
@Dineshkarthik Dineshkarthik removed the wontfix This will not be worked on label Mar 30, 2021
@Dineshkarthik Dineshkarthik moved this from Blocked to To do in Telegram-Media-Downloader Apr 10, 2021
@Dineshkarthik Dineshkarthik moved this from To do to In progress in Telegram-Media-Downloader Apr 10, 2021
@Dineshkarthik Dineshkarthik moved this from In progress to Done in Telegram-Media-Downloader Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging a pull request may close this issue.

1 participant