Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Issue with other pairs than BTC/ETH #2

Closed
Pusherman2 opened this issue Jun 1, 2022 · 3 comments
Closed

Issue with other pairs than BTC/ETH #2

Pusherman2 opened this issue Jun 1, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Pusherman2
Copy link

Hi there,

I noticed when using other pairs other than BTC/ETH, it will give the following error:
[2022-06-01T17:23:08Z INFO orderbook_delta_bot] The bot is not running live, no orders will be placed thread 'main' panicked at 'Multiplication overflowed'

Maybe it has to do with the precision required for each pair? What can we edit or adjust to be able to run for other pairs?

Kind regards.

@dineshpinto dineshpinto added the bug Something isn't working label Jun 1, 2022
@dineshpinto
Copy link
Owner

Hey,

It looks like it was unable to compute the order size for altcoins with non-fractional order sizes (eg. SHIB).
I've fixed this in the latest commit.

Thanks for raising the issue :)

Cheers

@Pusherman2
Copy link
Author

Hi there,

Thank you for your reply and commit, much appreciated. However, I noticed it currently works with SHIB but not for example with GMT/SOL. Is there something else which needs to be changed to allow for those pairs?

Kind regards.

dineshpinto added a commit that referenced this issue Jun 2, 2022
@dineshpinto
Copy link
Owner

Hey,

Thanks for reporting it.
This was an issue with the price precision. I put in a bug fix for it for the time being, and it works. But I'm not very happy with it.

I will look into rewriting this section once I get more familiar with the behavior of the Decimal crate

Cheers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants