Implement intrinsic for total order comparison on floating point types. #205
Conversation
soc
force-pushed
the
topic/total-order-new
branch
2 times, most recently
from
f729f38
to
144a7c0
Compare
soc
force-pushed
the
topic/total-order-new
branch
from
144a7c0
to
7845a11
Compare
This comment has been minimized.
This comment has been minimized.
soc
force-pushed
the
topic/total-order-new
branch
from
7845a11
to
35163c5
Compare
|
Welp, looks like it's broken on cannon now – I can't sort out what the problem here is... For reference, here is the Godbolt output, and here is the Dora implementation (that works). |
|
|
soc
force-pushed
the
topic/total-order-new
branch
2 times, most recently
from
21e066d
to
82cbfb9
Compare
|
Well, as mentioned on Gitter, the use of legacy instructions that clobbered a fixed register was the reason the code didn't work for ages. |
soc
force-pushed
the
topic/total-order-new
branch
from
82cbfb9
to
a53bf67
Compare
|
@dinfuehr Could you have a look? |
soc
force-pushed
the
topic/total-order-new
branch
from
a53bf67
to
dd852e3
Compare
|
As requested, I replaced the macro assembler calls with direct assembler calls, could you have a look, @dinfuehr? |
|
@dinfuehr ping? |
soc
force-pushed
the
topic/total-order-new
branch
from
dd852e3
to
45c5bd0
Compare
|
@dinfuehr ping? |
|
CI fail is due to Ruby install: |
|
Looks like this one needs to be updated. Then we can merge it. |
soc
force-pushed
the
topic/total-order-new
branch
from
45c5bd0
to
2eb3eb8
Compare
|
@dinfuehr Rebased. |
soc
force-pushed
the
topic/total-order-new
branch
from
2eb3eb8
to
18cf452
Compare
|
@dinfuehr I rebased the commit on master such that the fixed CI could run again, can you have a look? |
|
Hey, had to revert this PR because the tests didn't work on arm64. |
|
What was the error? |
|
I think it was assertion failures in the sorting tests. |
|
It would have been nice if I had the chance to look at the error and fix it. In general, it feels like whatever problem occurs, the most time-consuming option is chosen for me to deal with. |
|
I think that's the end of my journey, fyi I closed my issues that I'd class as suggestion, and unsubscribed from those I'd consider bug reports. |
|
Nevertheless thanks! |
|
The experience as a contributor was simply a magnitude worse than whatever I had seen before. Wish you the best, and hope you can figure things out. It's sad, because I thought this language had potential, but in the end I have other projects where I feel my efforts are actually appreciated and not treated as a nuisance. Let me know if you want dora-lang.org then I transfer it, otherwise I'll let the registration run out. |
No description provided.