Feature/remove constants validation #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move GO BACK on top of options move RUN SCRAPER at the top easier navigation
readability
dynamically create content based on registered items refactor to use tuples instead of lists move BACK option at the top
uses list of dicts to store handlers api unchanged added utility methods refactor tests to adapt to changes
Feature/manager refactor
needed to update test when refactoring for manager dialects
something broke. found temporary ugly solution
all this validation should in theory go away soon
Feature/manager dialects
move GO BACK on top of options move RUN SCRAPER at the top easier navigation
readability
dynamically create content based on registered items refactor to use tuples instead of lists move BACK option at the top
…hino/stocks-historical-data into feature/24-cli-improvements
function has been moved inside manager so it's useless
ensure that they are in csv module
use the new manager functionalities to dynamically create most of the settings menus improve user experience with sorting fields and defaulting to selecting current option if possible
changed default csv dialect in settings to excel, for no custom selected
the decorator registers some default components for testing
shuffle all directories around to a more proper package structure refactor imports add/cleanup some testing - increased coverage
component is still hugely work in progress, no need to cover it
as long as components are created the right way they are auto added to the cli
Completed core restructuring of the project file. Started working on implementing automated creation on cli options components are now following request on issue, so this closes #44 still missing reorganization of tests to follow same scheme so parallel work can be done on different sources and outputs
move the register by module directly into manager refactor and cleanup cli to use them cleanly functions naming is still up for discussion
update setup.py for new structure rename app in stonks-cli since it causes me problems with calling it
bump to v0.6.0 - will publish on 0.6.x when other things are done added automated registration functionalities to manager restructured whole file structure changed setup.py command to `stonks-cli`
typo in paths
concept stage, wasn't meant to be commited
|
aaand yet again wrong target branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all the
CONSTANTclasses and related validation.Validation will be done using components modules and
managersingleton instead, so it should be completely dynamicFinally closes #44 when merged..?