Feature/manager dialects #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed to update test when refactoring for manager dialects
something broke. found temporary ugly solution
all this validation should in theory go away soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added handling for dialects in manager
move actual csv dialect registration in manager
include default csv dialects in cli menu selection
The problem appeared randomly but makes sense, and it's between
settings.constantsandsettings.exceptionsFor the moment that's solved by moving one of the imports to the bottom but it needs to be solved. Since i'm thinking about restructuring the components directory and removing the validations (see #44) for now it will have to stay like this.