WIP Bedrock support #31
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #31 +/- ##
=============================================
+ Coverage 88.70% 88.73% +0.02%
- Complexity 44 56 +12
=============================================
Files 1 1
Lines 186 222 +36
=============================================
+ Hits 165 197 +32
- Misses 21 25 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Notice about PHP 7 version was updated, as PHP 8 will be EOL soon.
Still a WIP. Need to fix tests, and test on bedrock projects for plugin and themes, and check if it will work in a regular projects like it did before.
Replace dirname with __FILE__ to __DIR__ and create a separate bootstrap files for bedrock, as the vendor file is usually at the project root, not where the theme or plugin is located.
Adding a required theme slug parameter is a bc change, as the command would fail if we just run it with theme option.
dingo-d
force-pushed
the
feature/bedrock-support
branch
from
9f7bbd5
to
17f6b84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for Bedrock.
Still a WIP, as I'm still getting some errors when running the tests on Bedrock-type installs.
Also, need to update the changelog.
Closes #30
Checklist: