Adding velocity or time parameter to .addNote() does nothing.

[jwktje]

When calling this function the last two parameters are ignored:
track.addNote(0, 50, 32, 0, 32, 127);

The readme says these parameters are able to be given.
The jsmidgen code seems to suggest these parameters are not used.

Can you help me figure out what's going wrong?

[dingram]

You're partially correct 😃

The function call you've given as an example has six arguments, whereas the README says that addNote() accepts up to five arguments. As you noted, the code itself doesn't actually accept a velocity argument for addNote().

I'll fix addNote() to accept a velocity argument as the docs say it should. What other argument were you expecting?

[jwktje]

Oops, yeah. I just typed out that example quickly. The second to last "32" should be ignored. I meant:
track.addNote(0, 50, 32, 0, 127);
Meaning:
Channel = 0
Note/Pitch = 50
Duration = 32 ticks
Time = 0
Velocity = 127

I would love to have the option for a velocity parameter. It seems that it just takes the default velocity set in the code. Is there a way to override this default without changing it the jsmidgen code?

Just wanna also mention, I'm loving this module you've written.
I'm including this module inside a Meteor app and I'm building a crazy insane art installation with it.
It honestly wouldn't be possible without your code, so thanks for making my hobby project a reality

[dingram]

Thanks! I've fixed the code, and I'll be looking to release a new version to the NPM repository soon.