Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master: Fix forced unwrapped that was causing crashes. #1

Merged
merged 1 commit into from
Jul 5, 2017
Merged

master: Fix forced unwrapped that was causing crashes. #1

merged 1 commit into from
Jul 5, 2017

Conversation

LucianoPAlmeida
Copy link
Contributor

@LucianoPAlmeida LucianoPAlmeida commented Jul 5, 2017

Fixing force unwrapped properties parser, because some time when the field doesn't contains on the json or is not the expected type it crashes the App.
screen shot 2017-07-05 at 15 58 28

@dingwilson
Copy link
Owner

Thanks @LucianoPAlmeida for taking the time to fix this! :) I had actually planned on going back and rewriting this API wrapper, as there are many things (this force unwrapping being one of them) that are incorrect with this library, but simply haven't had the time.

@dingwilson dingwilson merged commit 90ad6da into dingwilson:master Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants