-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated README with FFmpeg blog post and fixed typos #62
Conversation
Please lmk if there are any changes I should make to the blog post. 👍 |
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=======================================
Coverage 86.36% 86.36%
=======================================
Files 3 3
Lines 176 176
Branches 13 13
=======================================
Hits 152 152
Misses 23 23
Partials 1 1 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The blog post looks tight. I think you should make the link more enticing, letting them know there's a nice walk though behind this link. Something like "short how-to here"
There is an unrelated error in the README, can you fix before merge? |
Wait I'll try to do it real quick |
Ok I don't know how to do all the git stuff required |
Sure, whats the issue haha |
VideoBackground.shared.play( I think it should be |
btw for future reference: git fetch origin readme # fetch readme branch
git checkout readme # checkout readme branch
<make changes>
git push origin readme # push changes to GH
git checkout master # checkout master branch
git branch -D readme # delete readme branch |
Ahhh thx |
What does this PR do?
Updates README with link to FFmpeg blog post
What issues (if any) are related to this PR? Or why was this change introduced?
Closes #56
Checklist