Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README with FFmpeg blog post and fixed typos #62

Merged
merged 3 commits into from
Mar 3, 2018
Merged

Conversation

dingwilson
Copy link
Owner

What does this PR do?

Updates README with link to FFmpeg blog post

What issues (if any) are related to this PR? Or why was this change introduced?

Closes #56

Checklist

  • Does this contain code changes?
  • Does this have tests?
  • Does this have documentation?
  • Does this break the public API (Requires major version bump)?
  • Is this a new feature (Requires minor version bump)?

@dingwilson dingwilson requested a review from quanvo87 March 3, 2018 06:01
@dingwilson
Copy link
Owner Author

Please lmk if there are any changes I should make to the blog post. 👍

@dingwilsonbot
Copy link

dingwilsonbot commented Mar 3, 2018

1 Message
📖 Executed 7 tests, with 0 failures (0 unexpected) in 0.062 (0.065) seconds

Generated by 🚫 Danger

@codecov
Copy link

codecov bot commented Mar 3, 2018

Codecov Report

Merging #62 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   86.36%   86.36%           
=======================================
  Files           3        3           
  Lines         176      176           
  Branches       13       13           
=======================================
  Hits          152      152           
  Misses         23       23           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d1b879...c218e68. Read the comment docs.

Copy link
Contributor

@quanvo87 quanvo87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The blog post looks tight. I think you should make the link more enticing, letting them know there's a nice walk though behind this link. Something like "short how-to here"

quanvo87
quanvo87 previously approved these changes Mar 3, 2018
@quanvo87
Copy link
Contributor

quanvo87 commented Mar 3, 2018

There is an unrelated error in the README, can you fix before merge?

@quanvo87
Copy link
Contributor

quanvo87 commented Mar 3, 2018

Wait I'll try to do it real quick

@quanvo87
Copy link
Contributor

quanvo87 commented Mar 3, 2018

Ok I don't know how to do all the git stuff required

@dingwilson
Copy link
Owner Author

Sure, whats the issue haha

@quanvo87
Copy link
Contributor

quanvo87 commented Mar 3, 2018

VideoBackground.shared.play(
view: view,
name: "myVideo",
type: "mp4",
darkness: 0.25,
isMuted: false,
willLoopVideo: true,
setAudioSessionAmbient: true
)

I think it should be videoName and videoType

@dingwilson
Copy link
Owner Author

btw for future reference:

git fetch origin readme # fetch readme branch
git checkout readme # checkout readme branch
<make changes>
git push origin readme # push changes to GH
git checkout master # checkout master branch
git branch -D readme # delete readme branch

@dingwilson dingwilson changed the title Updated README with link to FFmpeg blog post Updated README with FFmpeg blog post and fixed typos Mar 3, 2018
@quanvo87
Copy link
Contributor

quanvo87 commented Mar 3, 2018

Ahhh thx

@dingwilson dingwilson merged commit eb3f102 into master Mar 3, 2018
@dingwilson dingwilson deleted the readme branch March 3, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants