Use the poll() instead of select() for check state of the socket . #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It need for use fd more then 1024
default is on.
default is on.
Conflicts: src/data-types/mailstream_socket.c
poll used by default, but optionaly can use select (set use_poll=no in confugure)
poll used by default, but optionaly can use select (set use_poll=no in confugure)
Conflicts: src/data-types/mailstream_socket.c src/data-types/mailstream_ssl.c
| @@ -156,6 +156,14 @@ AC_CHECK_HEADERS(netdb.h netinet/in.h sys/socket.h) | |||
| AC_CHECK_HEADERS(sys/param.h sys/select.h inttypes.h) | |||
| AC_CHECK_HEADERS(arpa/inet.h winsock2.h) | |||
|
|
|||
| use_poll=yes | |||
There was a problem hiding this comment.
Could you set poll() not to be used by default for now since it's a risky change?
I'd like to test it for a little bit before making it the default.
Use: AC_ARG_WITH() so that we can use:
$ ./configure --with-poll
|
I did it. |
|
Could you investigate the build breakage, at least for Linux? |
|
Last commit fix it. No? |
| r = select(max_fd + 1, &fds_read, &fds_write, NULL, &timeout); | ||
| if (r <= 0) | ||
| if (r < 0) |
There was a problem hiding this comment.
why did you change it from <= 0 to < 0?
Thanks! I think when I commented on it, it was still red. It probably happened simultaneously :) |
+ more one select() changed to poll()
|
I found more one select() and review fix. |
| r = select(max_fd + 1, &fds_read, NULL, NULL, &timeout); | ||
| if (r <= 0) | ||
| return -1; | ||
|
|
||
| cancelled = (FD_ISSET(fd, &fds_read)); |
|
have you more comments? |
|
It looks all good now! Thanks for helping with that feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
poll used by default. Optionally can use select() (set use_poll=no in configure)
It need for correct working with file descriptors more then 1023.