Negotiate highest available SSL/TLS version #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When encrypting the connection with STARTTLS the only method allowed was TLSv1. Change this to allow TLSv1.2 (or whatever the strongest method is). Additionally tls_data_new() and ssl_data_new() did the same (with exception to the nailed method in tls_data_new()), so drop one of them.
| #if (OPENSSL_VERSION_NUMBER >= 0x10100000L) | ||
| TLS_client_method(), | ||
| #else | ||
| /* Despite their name the SSLv23_*method() functions have nothing to do |
There was a problem hiding this comment.
Is it also the behavior with OpenSSL < 1.1?
It would be great :)
|
OpenSSL >= 1.1.0 (which has not been released yet) has Both do the same, negotiate highest available SSL/TLS version. That is in order: |
dinhvh
added a commit
that referenced
this pull request
Mar 9, 2016
Negotiate highest available SSL/TLS version
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When encrypting the connection with STARTTLS the only method
allowed was TLSv1. Change this to allow TLSv1.2 (or whatever the
strongest method is).
Additionally tls_data_new() and ssl_data_new() did the same (with
exception to the nailed method in tls_data_new()), so drop one
of them.
fixes #226