Build failure on Fedora 31 and Fedora 32, vala-0.45.91-1.fc31

[bowlofeggs]

Dino fails to build on Fedora 31 and Fedora 32. In both cases, it seems that vala-0.45.91-1.fc31 is in use. You can see the full build logs here and here, but I think this might be the relevant bit:

[51/563] Generating C code for target QLITE_VALA_C
FAILED: qlite/src/database.c qlite/src/table.c qlite/src/column.c qlite/src/row.c qlite/src/statement_builder.c qlite/src/delete_builder.c qlite/src/insert_builder.c qlite/src/query_builder.c qlite/src/update_builder.c qlite/src/upsert_builder.c exports/qlite.vapi exports/qlite_internal.vapi exports/qlite.h exports/qlite_internal.h 
cd /builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/build/qlite && /usr/bin/valac -C --header=/builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/build/exports/qlite.h --internal-header=/builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/build/exports/qlite_internal.h --vapi=/builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/build/exports/qlite.vapi --internal-vapi=/builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/build/exports/qlite_internal.vapi -b /builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/qlite -d /builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/build/qlite --pkg=gee-0.8 --pkg=glib-2.0 --pkg=gobject-2.0 --pkg=sqlite3 -g --target-glib=2.38 /builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/qlite/src/database.vala /builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/qlite/src/table.vala /builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/qlite/src/column.vala /builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/qlite/src/row.vala /builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/qlite/src/statement_builder.vala /builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/qlite/src/delete_builder.vala /builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/qlite/src/insert_builder.vala /builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/qlite/src/query_builder.vala /builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/qlite/src/update_builder.vala /builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/qlite/src/upsert_builder.vala
/builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/qlite/src/column.vala:58.5-58.17: error: Creation method of abstract class cannot be public.
    public Column(string name, int type) {
    ^^^^^^^^^^^^^
/builddir/build/BUILD/dino-016ab2c19b0760792f3ea8f00bfc46b49500f96a/qlite/src/statement_builder.vala:18.9-18.28: error: Creation method of abstract class cannot be public.
        public AbstractField(T value) {
        ^^^^^^^^^^^^^^^^^^^^
Compilation failed: 2 error(s), 0 warning(s)

I'm not familiar with Vala, so I'm not sure what the fix should be (unless we can simply drop the use of the keyword public, but I would guess this is public on purpose?)

[bowlofeggs]

It seems that the error is mentioned in the 0.45.1 release notes:

https://gitlab.gnome.org/GNOME/vala/raw/master/NEWS

This is the referenced issue:

https://gitlab.gnome.org/GNOME/vala/issues/766

[bowlofeggs]

For ease of reference, this is the first code block referenced:

dino/qlite/src/column.vala

Lines 58 to 61 in 016ab2c

	public Column(string name, int type) {
	this.name = name;
	this.sqlite_type = type;
	}

This is the second:

dino/qlite/src/statement_builder.vala

Lines 18 to 20 in 016ab2c

	public AbstractField(T value) {
	this.value = value;
	}

[mar-v-in]

I think we can just leave out the public in our case, it's not strictly necessary to have it there.