Do the TLS handshake in an asynchronous task to avoid blocking the service #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rvice This may happen when a partial TLS handshake is being done by one client, which blocks any other clients from establishing a TLS connection (since all is done within the main task). Reproduce by running: echo 1603034800 | perl -e 'print pack "H*", <STDIN>' | nc $host 443 and attempting to establish a https connection to the same host Adapted 8684c71 to 0.0.8 separate tcp connection from tls connection Co-Authored-By: Lucas Pluvinage <lucas@tarides.com>
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
May 21, 2022
CHANGES: - Do the TLS handshake in an asynchronous task (@TheLortex, @hannesm, dinosaure/paf-le-chien#64)
|
Thanks, I did the release and I will try to integrate your reproducible test into the distribution 👍. |
|
Thank you very much. To explain the test: it opens a TCP connection and sends a TLS header (handhsake frame = 0x16; version = 0x03 0x03; length = 0x4800 = 18432), so the TLS reader waits for another 18432 before continuing processing the data. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would it be possible for you to create a 0.0.8 branch, merge this commit in there, and release a 0.0.8.1? Thanks a lot.
This may happen when a partial TLS handshake is being done by one client, which
blocks any other clients from establishing a TLS connection (since all is done
within the main task).
Reproduce by running:
echo 1603034800 | perl -e 'print pack "H*", ' | nc $host 443
and attempting to establish a https connection to the same host
Adapted 8684c71 to 0.0.8
separate tcp connection from tls connection
Co-Authored-By: Lucas Pluvinage lucas@tarides.com