Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve inequalities in extended reals #1067

Merged
merged 8 commits into from Oct 16, 2020
Merged

Solve inequalities in extended reals #1067

merged 8 commits into from Oct 16, 2020

Conversation

skirpichev
Copy link
Collaborator

No description provided.

@skirpichev skirpichev added this to the 0.12 milestone Sep 26, 2020
@skirpichev skirpichev force-pushed the ineq-in-extended_reals branch 6 times, most recently from 00c075c to 4d929dc Compare October 13, 2020 08:45
@skirpichev
solvers: use ExtendedReals subsets to solve inequalities
085a22d 
That's consistent with the general linear solver and make
things more compact in the relational representation
of solutions.
@skirpichev
Exclude infinites in minimize() constraints
cca4b31
@skirpichev
Use ExtendedReals subsets in Piecewise.as_expr_set_pairs()
3ec8b9b
@skirpichev skirpichev marked this pull request as ready for review October 16, 2020 08:42
@skirpichev
Copy link
Collaborator Author

Few tests seems to be wrong:

In [2]: reduce_inequalities(-1 + 1/abs(1/x - 1) < 0)
Out[2]: (0 < x ∧ x < 1/2) ∨ x < 0

In [3]: limit(-1 + 1/abs(1/x - 1) < 0, x, -oo)
Out[3]: false

In [4]: reduce_inequalities(x/(x + 1) > 1, x)
Out[4]: x < -1

In [5]: limit(x/(x + 1) > 1, x, -oo)
Out[5]: false

Probably, we should test infinities in the rational functions case.

@skirpichev skirpichev merged commit 1d220d4 into diofant:master Oct 16, 2020
@skirpichev skirpichev deleted the ineq-in-extended_reals branch October 16, 2020 08:58
skirpichev added a commit to skirpichev/diofant that referenced this pull request Jan 18, 2021
@skirpichev
solvers: correct infinite boundaries case for reduce_inequalities()
eded24a 
This is a rough fix for the problems, mentioned in
diofant#1067 (comment)
skirpichev added a commit to skirpichev/diofant that referenced this pull request Jan 18, 2021
@skirpichev
solvers: correct infinite boundaries case for reduce_inequalities()
d8fe182 
This is a rough fix for the problems, mentioned in
diofant#1067 (comment)
@diofant diofant deleted a comment from github-actions bot Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
functions sets solvers testing
Projects
Stable algebraic equations solver
Status: Done
Milestone
0.12
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@skirpichev