Improve evaluation of Intersection's for FiniteSet with symbolic elements #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
force-pushed
the
symbols-in-sets
branch
from
42ac8a5
to
cf41470
Compare
skirpichev
force-pushed
the
symbols-in-sets
branch
from
cf41470
to
30aeff2
Compare
skirpichev
force-pushed
the
symbols-in-sets
branch
2 times, most recently
from
2e1aa61
to
ac8bd12
Compare
skirpichev
force-pushed
the
symbols-in-sets
branch
from
b4c713e
to
f03e9c1
Compare
…ents For example, now FiniteSet(x).intersect(Reals) is NOT EmptySet. fixes sympy/sympy#8217
Conflicts: sympy/sets/tests/test_sets.py // edited by skirpichev
// edited by skirpichev
skirpichev
force-pushed
the
symbols-in-sets
branch
from
a140600
to
33ee84d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see sympy/sympy#8508
a replacement for #11 (travis-ci won't build old pr?)
I believe, we should be more careful for FiniteSet's with symbolic elements also in following cases:
We can iterate over this set only if elements are non-Symbols.