Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes #1387

Merged
merged 18 commits into from Mar 28, 2024
Merged

Misc fixes #1387

merged 18 commits into from Mar 28, 2024

Conversation

skirpichev
Copy link
Collaborator

No description provided.

Actually, _div() and friends can't return None.  Now only this helper
has the NotImplementedError condition.  This amends 1b6e079.
@skirpichev skirpichev added this to the 0.15 milestone Mar 27, 2024
@skirpichev skirpichev added polys bug an unexpected problem or unintended behavior labels Mar 27, 2024
diofant/polys/factorization_alg_field.py Dismissed Show dismissed Hide dismissed
diofant/polys/modulargcd.py Fixed Show fixed Hide fixed
f_ was rescalled, so should be adjusted fA
The divisors[i] == 1 condition is excluded by test on L361 of the
_test_evaluation_points() helper.
diofant/polys/factortools.py Dismissed Show dismissed Hide dismissed
@skirpichev skirpichev merged commit 5d22d82 into diofant:master Mar 28, 2024
8 checks passed
@skirpichev skirpichev deleted the misc branch March 28, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior maintainability polys testing
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant