Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old, Expr-derived AlgebraicNumber class #631

Merged
merged 1 commit into from Jun 15, 2018
Merged

Remove old, Expr-derived AlgebraicNumber class #631

merged 1 commit into from Jun 15, 2018

Conversation

skirpichev
Copy link
Collaborator

@skirpichev skirpichev commented Mar 16, 2018 •
edited

see sympy/sympy#14389

  • test_simplify_AlgebraicNumber
  • test_AlgebraicNumber
  • rename AlgebraicElement -> AlgebraicNumber?
  • test_to_algebraic_integer
  • test_C20
  • test_C21

@skirpichev skirpichev added this to the 0.10 milestone Mar 16, 2018
@skirpichev skirpichev force-pushed the remove-AlgebraicNumber branch 2 times, most recently from 0435761 to 54d9951 Compare June 3, 2018 16:34
@skirpichev skirpichev changed the title [wip] Removed AlgebraicNumber [wip] Remove old, Expr-derived AlgebraicNumber class Jun 12, 2018
@skirpichev skirpichev force-pushed the remove-AlgebraicNumber branch 3 times, most recently from 0f9554b to 381abf7 Compare June 13, 2018 18:18
@skirpichev skirpichev changed the title [wip] Remove old, Expr-derived AlgebraicNumber class Remove old, Expr-derived AlgebraicNumber class Jun 13, 2018
@skirpichev skirpichev force-pushed the remove-AlgebraicNumber branch 2 times, most recently from d8de67c to ffb7e5b Compare June 14, 2018 11:30
@skirpichev
Removed old, Expr-derived AlgebraicNumber class
cb6e730 
There are little regression in supporting simplifications of
algebraic numbers.  Former AlgebraicNumber._eval_simplify()
method was naive and not very powerful.
@skirpichev skirpichev merged commit 59e557c into diofant:master Jun 15, 2018
@skirpichev skirpichev deleted the remove-AlgebraicNumber branch June 15, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
core domains maintainability polys
Projects
None yet
Milestone
0.10
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@skirpichev