Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom SQL query option #48

Merged
merged 2 commits into from Jan 28, 2018
Merged

Conversation

abarrak
Copy link
Contributor

@abarrak abarrak commented Jan 28, 2018

This PR gives fine grained control over SQL query that generates CSV file.

This is to address customized data reports and fetched sets beyond AR that we needed, where it was inefficient to have them in memory for conversion from result set to AR relation.

@diogob
Copy link
Owner

diogob commented Jan 28, 2018

Thanks for the PR 👍
That is indeed a nice feature to have and the implementation is quite simple.

@diogob diogob merged commit ff07588 into diogob:master Jan 28, 2018
@abarrak abarrak deleted the support-custom-sql branch January 29, 2018 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants