Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo #24

Merged
merged 1 commit into from
Mar 11, 2018
Merged

Conversation

blakfeld
Copy link
Contributor

@blakfeld blakfeld commented Mar 9, 2018

Hiya!

Great module! I noticed that "updateNode" is listed as "udpateNode" everywhere, so here's a pull request fixing that typo!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.529% when pulling 321e4b9 on blakfeld:fixing-updateNode-typo into 701e354 on diogofcunha:master.

@codecov-io
Copy link

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #24   +/-   ##
=======================================
  Coverage   94.87%   94.87%           
=======================================
  Files          14       14           
  Lines         117      117           
=======================================
  Hits          111      111           
  Misses          6        6
Impacted Files Coverage Δ
src/renderers/Favorite.js 100% <100%> (ø) ⬆️
src/selectors/nodes.js 96.15% <100%> (ø) ⬆️
src/renderers/Expandable.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 701e354...321e4b9. Read the comment docs.

Copy link
Owner

@diogofcunha diogofcunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @blakfeld, thanks for your contribution 👍

@diogofcunha diogofcunha merged commit 774c409 into diogofcunha:master Mar 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants