Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize bundle #38

Merged
merged 3 commits into from
May 15, 2018
Merged

Optimize bundle #38

merged 3 commits into from
May 15, 2018

Conversation

diogofcunha
Copy link
Owner

@diogofcunha diogofcunha commented May 15, 2018

TODO:

  • Add stats plugin
  • Add needed externals
  • Don't import lodash

Before:

react-dom, react-virtualized and full lodash included in the build

umd sizes after gzip:

umd/react-virtualized-tree.js 322.58 KB
umd/react-virtualized-tree.min.js 221.37 KB

After:

react-dom, react-virtualized set as externals. Importing only needed lodash operators.

umd sizes after gzip:

umd/react-virtualized-tree.js 28.05 KB
umd/react-virtualized-tree.min.js 22.08 KB

@diogofcunha diogofcunha added this to the 2.0.0 milestone May 15, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.529% when pulling dfe6da3 on optimize-bundle into 692177a on master.

@diogofcunha diogofcunha merged commit 0f636f2 into master May 15, 2018
@diogofcunha diogofcunha deleted the optimize-bundle branch May 15, 2018 18:47
@codecov-io
Copy link

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   94.82%   94.82%           
=======================================
  Files          15       15           
  Lines         116      116           
=======================================
  Hits          110      110           
  Misses          6        6
Impacted Files Coverage Δ
src/selectors/nodes.js 96.15% <ø> (ø) ⬆️
src/FilteringContainer.js 94.11% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 692177a...dfe6da3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants