Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xcode_summary not reporting some items in #43

Open
KingOfBrian opened this issue Jun 4, 2019 · 0 comments
Open

xcode_summary not reporting some items in #43

KingOfBrian opened this issue Jun 4, 2019 · 0 comments

Comments

@KingOfBrian
Copy link

KingOfBrian commented Jun 4, 2019

When I run danger, xcode_summary is only printing the tests_summary_messages. I get the following comment reported

Messages:
- [ ] Executed 165 tests, with 0 failures (0 unexpected) in 3.715 (3.884) seconds

But my formatted report has a number of warnings and compile warnings:

{
  "warnings": [
    "Skipping file at /srv/jenkins/workspace/Project_PR-3029/Target/Generated/EnumList.generated.swift as it does not exist",
  ],
  "ld_warnings": [
    "ld: Some object files have incompatible Objective-C category definitions. Some category metadata may be lost. All files containing Objective-C categories should be built using the same compiler.",
    "ld: Some object files have incompatible Objective-C category definitions. Some category metadata may be lost. All files containing Objective-C categories should be built using the same compiler.",
    "ld: "
  ],
  "compile_warnings": [
    {
      "file_name": "RandomViewController.swift",
      "file_path": "/srv/jenkins/workspace/Project_PR-3029/Target/Domains/watches/RandomViewController.swift:326:19",
      "reason": "value 'state' was defined but never used; consider replacing with boolean test",
      "line": "        guard let state = state else { return }",
      "cursor": "              ~~~~^~~~~~~~"
    },
  ],
  "errors": [

  ],
  "compile_errors": [

  ],
  "file_missing_errors": [

  ],
  "undefined_symbols_errors": [

  ],
  "duplicate_symbols_errors": [

  ],
  "tests_failures": {
  },
  "tests_summary_messages": [
    "\t Executed 165 tests, with 0 failures (0 unexpected) in 2.997 (3.224) seconds\n"
  ]
}

FYI: This was built with:

xcodebuild -workspace '/srv/jenkins/workspace/Product_PR-3029/Product.xcworkspace' 
-scheme Product 
-configuration Debug 
-destination 'platform=iOS Simulator,id=D6D05C2E-0C0A-4229-B0E0-66154D3D7011' 
-derivedDataPath '/srv/jenkins/workspace/Product_PR-3029/derivedData/Product-jenkins' 
-resultBundlePath '/srv/jenkins/workspace/Product_PR-3029/output/result.bundle' 
-only-testing:TargetTests 
clean build test 
| XCPRETTY_JSON_FILE_OUTPUT='/srv/jenkins/workspace/Product_PR-3029/output/report-formatted.json' xcpretty -f `xcpretty-json-formatter`

and gems:

Using danger 5.16.1
Using danger-plugin-api 1.0.0
Using danger-swiftlint 0.19.0
Using danger-xcode_summary 0.5.0
Using danger-xcprofiler 0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant