Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check specifically for file url in document_location, fixing crash in Xcode 15 when running in Apple Silicon #82

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Check specifically for file url in document_location, fixing crash in Xcode 15 when running in Apple Silicon #82

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fbb2ba6
check specifically for file url in failure_message, fixing crash with…
bpollman Nov 14, 2023
87ec44b
check for nil location
bpollman Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/xcode_summary/plugin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def errors(action)
end

def parse_location(document_location)
return nil if document_location.nil?
return nil if document_location&.url.nil?

file_path = document_location.url.gsub('file://', '').split('#').first
file_name = file_path.split('/').last
Expand Down Expand Up @@ -245,6 +245,8 @@ def format_warning(result)
end

def format_test_failure(result, producing_target, test_case_name)
return escape_reason(result.message) if result.location.nil?

path = result.location.file_path
path_link = format_path(path, result.location.line)
suite_name = "#{producing_target}.#{test_case_name}"
Expand Down