Fix node swapping when not a leaf node

[diogox]

Reported here.

Should just be a matter of querying the swapped node and make sure that it's a leaf node.
If not, I need to get its children and handle each one of them accordingly.

It begs the question: Which leaf node should be focused in the destination's monocle mode? The biggest one?

[ortango]

It begs the question: Which leaf node should be focused in the destination's monocle mode? The biggest one?

i believe as it works now in bspwm what would happen is:

• if there was a focused window in that tree it would get focus.
• if the focused node was not a leaf then it would end up focusing the "last" window (i'm not sure of the right word, i don't mean last focused, or the deepest, but last if you traversed the tree in order).

[diogox]

I've pushed v0.0.3 that, I believe, fixes non-leaf node swapping. Could you check if it's been fixed on your machine as well?

It doesn't however, handle it in the way you described. It will focus a "random" node from the swapped tree.

To implement the behavior you described, I'll have to do some refactoring.

I'll create a new ticket to implement the correct behavior once that's done.

[diogox]

Reopening until I have your confirmation. To avoid forgetting about this

[ortango]

yep happy to confirm this seems fixed here.

i'll update the other issue with a comment describing the exact behavior when i get some time. i believe that the actual behavior is a little different then what i initially posted.

[diogox]

Great ^^
Closing this then!