Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Add Module and Edit Module have the same tabs/fields #2

Closed
rdiaztushman opened this issue Jan 16, 2014 · 7 comments
Closed

Comments

@rdiaztushman
Copy link
Member

All the fields from the edit form need to be in the create form

@ChrisFrench
Copy link
Member

How do you plan to request the edit field from the module?

do you think something like how joomla does it where you see a new modules model window and than hitting it gives you a new module or something

@rdiaztushman
Copy link
Member Author

No, it'll work just like in the Edit module form, where the list of recognized system modules is in a dropdown, and when you change to a new module, the new module's custom fields get displayed

@ChrisFrench
Copy link
Member

How do you want to process the fields, do you want to reload the page? or
do you want to do some kinda ajax call

On Thu, Jan 16, 2014 at 9:58 AM, Rafael Diaz-Tushman <
notifications@github.com> wrote:

No, it'll work just like in the Edit module form, where the list of
recognized system modules is in a dropdown, and when you change to a new
module, the new module's custom fields get displayed


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-32488088
.

@rdiaztushman
Copy link
Member Author

It already does an ajax call whenever the select list changes. That's how both the creation and the editing forms work (I already did that). That part isn't what's missing. The only thing that's missing is the "Display" tab from the Editing form.

@ChrisFrench
Copy link
Member

Oh that is funny, I didn't notice it did that because i was moving around
the page so fast, that i selected to the type too fast and it did load.

On Thu, Jan 16, 2014 at 10:03 AM, Rafael Diaz-Tushman <
notifications@github.com> wrote:

It already does an ajax call whenever the select list changes. That's how
both the creation and the editing forms work (I already did that). That
part isn't what's missing. The only thing that's missing is the "Display"
tab from the Editing form.


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-32488555
.

@ChrisFrench
Copy link
Member

this module system is even cooler than I already thought

@ChrisFrench ChrisFrench reopened this Jan 16, 2014
@rdiaztushman
Copy link
Member Author

hehe thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants