Indicate which dependency included a transitive lib with legacy support usage #16

carstenhag · 2020-12-10T09:01:00Z

carstenhag
Dec 10, 2020

Is your feature request related to a problem? Please describe.
Yes. I am including the mapbox libraries into our project. Mapbox depends on some okhttp version, which depends on a specific picasso version apparently. See mapbox/mapbox-navigation-android#3390 and mapbox/mapbox-navigation-android#2790 for more details.

I knew of this because I had commented there before, but bye-bye-jetifier should have indicated me that as well.

Describe the solution you'd like
Not sure to be honest if it's possible to look at which lib I included caused the actual legacy usage. A good solution for me would be to know that mapbox caused it.

Additional context

Scanning com.squareup.picasso:picasso:2.71828
/Users/carstenh/.gradle/caches/modules-2/files-2.1/com.squareup.picasso/picasso/2.71828/2bd10d289c94265b24e39e7d03762cef5eb445bc/picasso-2.71828.aar
 * com/squareup/picasso/FileRequestHandler.class -> android/support/media/ExifInterface

carstenhag · 2020-12-11T10:56:16Z

carstenhag
Dec 11, 2020
Author

Not sure if related, but can i drop jetifier (so not this tool) tells me these:

Cannot drop Jetifier due to following external dependencies:

* me.dm7.barcodescanner:zxing:1.9.13
* com.master.android:permissionhelper:2.1
* com.mapbox.navigation:ui:1.1.0

The navigation one contains picasso (through some hoops). The zxing lib is depended upon in my build.gradle directly, without hoops. bye-bye-jetifier doesn't find it, output of that below:

Scanning com.microsoft.appcenter:espresso-test-extension:1.4
/Users/carstenh/.gradle/caches/modules-2/files-2.1/com.microsoft.appcenter/espresso-test-extension/1.4/d95d919a5195d439334f79834fc5c6bc1dada78a/espresso-test-extension-1.4.aar
 * com/microsoft/appcenter/espresso/Factory.class -> android.support.test.InstrumentationRegistry

Scanning com.microsoft.appcenter:appcenter:4.0.0
/Users/carstenh/.gradle/caches/modules-2/files-2.1/com.microsoft.appcenter/appcenter/4.0.0/e36a3916067ec0652de1353a6c9875363b93ef4e/appcenter-4.0.0.aar
 * com/microsoft/appcenter/utils/InstrumentationRegistryHelper.class -> android.support.test.InstrumentationRegistry

Scanning com.master.android:permissionhelper:2.1
/Users/carstenh/.gradle/caches/modules-2/files-2.1/com.master.android/permissionhelper/2.1/b8d96a3ca233b7e828291d7ea4f5f39d4ea164d/permissionhelper-2.1.aar
 * com/master/permissionhelper/PermissionHelperJava.class -> android/support/v4/app/Fragment
 * com/master/permissionhelper/PermissionHelperJava.class -> android/support/v4/app/ActivityCompat
 * com/master/permissionhelper/PermissionHelperJava.class -> android/support/v4/content/ContextCompat
 * com/master/permissionhelper/PermissionHelperJava.class -> android/support/v4/app/FragmentActivity
 * com/master/permissionhelper/PermissionHelper$deniedCallback$1.class -> android/support/v4/app/Fragment
 * com/master/permissionhelper/PermissionHelper$requestAllCallback$1.class -> android/support/v4/app/Fragment
 * com/master/permissionhelper/PermissionHelper$requestIndividualCallback$1.class -> android/support/v4/app/Fragment
 * com/master/permissionhelper/PermissionHelper.class -> android/support/v4/app/Fragment
 * com/master/permissionhelper/PermissionHelper.class -> android/support/v4/app/ActivityCompat
 * com/master/permissionhelper/PermissionHelper.class -> android/support/v4/content/ContextCompat
 * com/master/permissionhelper/PermissionHelper.class -> android/support/v4/app/FragmentActivity

Scanning com.mixpanel.android:mixpanel-android:5.8.5
/Users/carstenh/.gradle/caches/modules-2/files-2.1/com.mixpanel.android/mixpanel-android/5.8.5/11cd1c3ab4c5c23ab080edcf015e8baaeb5d773a/mixpanel-android-5.8.5.aar
 * com/mixpanel/android/mpmetrics/MixpanelAPI.class -> android.support.v4.content.LocalBroadcastManager

Scanning com.squareup.picasso:picasso:2.71828
/Users/carstenh/.gradle/caches/modules-2/files-2.1/com.squareup.picasso/picasso/2.71828/2bd10d289c94265b24e39e7d03762cef5eb445bc/picasso-2.71828.aar
 * com/squareup/picasso/FileRequestHandler.class -> android/support/media/ExifInterface

Scanning org.robolectric:shadows-multidex:4.4
/Users/carstenh/.gradle/caches/modules-2/files-2.1/org.robolectric/shadows-multidex/4.4/33fbcaaf91449ec1aa74078024f07b219723fa/shadows-multidex-4.4.jar
 * org/robolectric/shadows/multidex/Shadows.class -> android/support/multidex/MultiDex
 * org/robolectric/shadows/multidex/Shadows.class -> android.support.multidex.MultiDex
 * org/robolectric/shadows/multidex/ShadowMultiDex.class -> android/support/multidex/MultiDex

Scanning org.parceler:parceler:1.1.12
/Users/carstenh/.gradle/caches/modules-2/files-2.1/org.parceler/parceler/1.1.12/96673fd2a9620915631b2a1c4b53b2f3ab508d64/parceler-1.1.12.jar

0 replies

maxirosson · 2020-12-14T14:54:46Z

maxirosson
Dec 14, 2020
Maintainer

Is this the complete report?

0 replies

carstenhag · 2020-12-14T15:31:11Z

carstenhag
Dec 14, 2020
Author

This is the complete report:

Project: app
=========================================

Scanning com.microsoft.appcenter:espresso-test-extension:1.4
/Users/carstenh/.gradle/caches/modules-2/files-2.1/com.microsoft.appcenter/espresso-test-extension/1.4/d95d919a5195d439334f79834fc5c6bc1dada78a/espresso-test-extension-1.4.aar
 * com/microsoft/appcenter/espresso/Factory.class -> android.support.test.InstrumentationRegistry

Scanning com.microsoft.appcenter:appcenter:2.5.1
/Users/carstenh/.gradle/caches/modules-2/files-2.1/com.microsoft.appcenter/appcenter/2.5.1/31d9c655bbb96a3aba6c3e9f8ecb9da2ac37a05e/appcenter-2.5.1.aar
 * com/microsoft/appcenter/utils/InstrumentationRegistryHelper.class -> android.support.test.InstrumentationRegistry

Scanning net.openid:appauth:0.7.1
/Users/carstenh/.gradle/caches/modules-2/files-2.1/net.openid/appauth/0.7.1/c525da16cff454f77c757bb95a161ee2962306ab/appauth-0.7.1.aar
 * net/openid/appauth/AuthorizationException.class -> android/support/v4/util/ArrayMap
 * net/openid/appauth/AuthorizationService.class -> android/support/customtabs/CustomTabsIntent$Builder
 * net/openid/appauth/AuthorizationService.class -> android/support/customtabs/CustomTabsIntent
 * net/openid/appauth/browser/CustomTabManager$1.class -> android/support/customtabs/CustomTabsServiceConnection
 * net/openid/appauth/browser/CustomTabManager$1.class -> android/support/customtabs/CustomTabsClient
 * net/openid/appauth/browser/CustomTabManager.class -> android/support/customtabs/CustomTabsIntent$Builder
 * net/openid/appauth/browser/CustomTabManager.class -> android/support/customtabs/CustomTabsIntent
 * net/openid/appauth/browser/CustomTabManager.class -> android/support/customtabs/CustomTabsClient
 * net/openid/appauth/browser/CustomTabManager.class -> android/support/customtabs/CustomTabsServiceConnection
 * net/openid/appauth/browser/CustomTabManager.class -> android/support/customtabs/CustomTabsCallback
 * net/openid/appauth/browser/CustomTabManager.class -> android/support/customtabs/CustomTabsSession
 * net/openid/appauth/internal/UriUtil.class -> android/support/v4/util/Pair

Scanning com.master.android:permissionhelper:2.1
/Users/carstenh/.gradle/caches/modules-2/files-2.1/com.master.android/permissionhelper/2.1/b8d96a3ca233b7e828291d7ea4f5f39d4ea164d/permissionhelper-2.1.aar
 * com/master/permissionhelper/PermissionHelperJava.class -> android/support/v4/app/Fragment
 * com/master/permissionhelper/PermissionHelperJava.class -> android/support/v4/app/ActivityCompat
 * com/master/permissionhelper/PermissionHelperJava.class -> android/support/v4/content/ContextCompat
 * com/master/permissionhelper/PermissionHelperJava.class -> android/support/v4/app/FragmentActivity
 * com/master/permissionhelper/PermissionHelper$deniedCallback$1.class -> android/support/v4/app/Fragment
 * com/master/permissionhelper/PermissionHelper$requestAllCallback$1.class -> android/support/v4/app/Fragment
 * com/master/permissionhelper/PermissionHelper$requestIndividualCallback$1.class -> android/support/v4/app/Fragment
 * com/master/permissionhelper/PermissionHelper.class -> android/support/v4/app/Fragment
 * com/master/permissionhelper/PermissionHelper.class -> android/support/v4/app/ActivityCompat
 * com/master/permissionhelper/PermissionHelper.class -> android/support/v4/content/ContextCompat
 * com/master/permissionhelper/PermissionHelper.class -> android/support/v4/app/FragmentActivity

Scanning com.mixpanel.android:mixpanel-android:5.8.5
/Users/carstenh/.gradle/caches/modules-2/files-2.1/com.mixpanel.android/mixpanel-android/5.8.5/11cd1c3ab4c5c23ab080edcf015e8baaeb5d773a/mixpanel-android-5.8.5.aar
 * com/mixpanel/android/mpmetrics/MixpanelAPI.class -> android.support.v4.content.LocalBroadcastManager

Scanning com.squareup.picasso:picasso:2.71828
/Users/carstenh/.gradle/caches/modules-2/files-2.1/com.squareup.picasso/picasso/2.71828/2bd10d289c94265b24e39e7d03762cef5eb445bc/picasso-2.71828.aar
 * com/squareup/picasso/FileRequestHandler.class -> android/support/media/ExifInterface

Scanning org.robolectric:shadows-multidex:4.4
/Users/carstenh/.gradle/caches/modules-2/files-2.1/org.robolectric/shadows-multidex/4.4/33fbcaaf91449ec1aa74078024f07b219723fa/shadows-multidex-4.4.jar
 * org/robolectric/shadows/multidex/Shadows.class -> android/support/multidex/MultiDex
 * org/robolectric/shadows/multidex/Shadows.class -> android.support.multidex.MultiDex
 * org/robolectric/shadows/multidex/ShadowMultiDex.class -> android/support/multidex/MultiDex

Scanning org.parceler:parceler:1.1.12
/Users/carstenh/.gradle/caches/modules-2/files-2.1/org.parceler/parceler/1.1.12/96673fd2a9620915631b2a1c4b53b2f3ab508d64/parceler-1.1.12.jar
 * org/parceler/internal/generator/MutableLiveDataReadWriteGenerator.class -> android.arch.lifecycle.MutableLiveData
 * org/parceler/internal/generator/ObservableFieldReadWriteGenerator.class -> android.databinding.ObservableField
 * org/parceler/internal/matcher/ObservableFieldMatcher.class -> android.databinding.ObservableField
 * org/parceler/internal/matcher/MutableLiveDataMatcher.class -> android.arch.lifecycle.MutableLiveData
 * org/parceler/internal/ParcelerModule.class -> android.databinding.ObservableArrayList
 * org/parceler/internal/ParcelerModule.class -> android.databinding.ObservableArrayMap

Legacy support dependencies:
 * android.arch.core:common:1.1.1
 * android.arch.core:runtime:1.1.1
 * android.arch.lifecycle:common:1.1.1
 * android.arch.lifecycle:livedata-core:1.1.1
 * android.arch.lifecycle:livedata:1.1.1
 * android.arch.lifecycle:runtime:1.1.1
 * android.arch.lifecycle:viewmodel:1.1.1
 * com.android.support:animated-vector-drawable:28.0.0
 * com.android.support:appcompat-v7:28.0.0
 * com.android.support:asynclayoutinflater:28.0.0
 * com.android.support:collections:28.0.0
 * com.android.support:coordinatorlayout:28.0.0
 * com.android.support:cursoradapter:28.0.0
 * com.android.support:customtabs:27.1.1
 * com.android.support:customview:28.0.0
 * com.android.support:documentfile:28.0.0
 * com.android.support:drawerlayout:28.0.0
 * com.android.support:exifinterface:27.1.0
 * com.android.support:interpolator:28.0.0
 * com.android.support:loader:28.0.0
 * com.android.support:localbroadcastmanager:28.0.0
 * com.android.support:print:28.0.0
 * com.android.support:slidingpanelayout:28.0.0
 * com.android.support:support-annotations:28.0.0
 * com.android.support:support-compat:28.0.0
 * com.android.support:support-core-ui:28.0.0
 * com.android.support:support-core-utils:28.0.0
 * com.android.support:support-fragment:28.0.0
 * com.android.support:support-media-compat:28.0.0
 * com.android.support:support-v4:28.0.0
 * com.android.support:support-vector-drawable:28.0.0
 * com.android.support:swiperefreshlayout:28.0.0
 * com.android.support:versionedparcelable:28.0.0
 * com.android.support:viewpager:28.0.0

=========================================
Project: appcenter
=========================================
 * No legacy android support usages found

=========================================
Project: instabug
=========================================
 * No legacy android support usages found

=========================================
Project: libaddressinput
=========================================
 * No legacy android support usages found

> Task :canISayByeByeJetifier FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':canISayByeByeJetifier'.
> You can not say Bye Bye Jetifier

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.7/userguide/command_line_interface.html#sec:command_line_warnings

BUILD FAILED in 43s
1 actionable task: 1 executed

0 replies

maxirosson · 2020-12-14T17:44:21Z

maxirosson
Dec 14, 2020
Maintainer

Ok. The problem is not directly on me.dm7.barcodescanner:zxing:1.9.13, the problem is on the transitive dependencies:

\--- me.dm7.barcodescanner:zxing:1.9.13
     +--- me.dm7.barcodescanner:core:1.9.13
     |    \--- com.android.support:support-v4:28.0.0
     |         +--- com.android.support:support-compat:28.0.0
     |         |    +--- com.android.support:support-annotations:28.0.0
     |         |    +--- com.android.support:collections:28.0.0
     |         |    |    \--- com.android.support:support-annotations:28.0.0
...

It seems that me.dm7.barcodescanner:core:1.9.13 is declaring the support but not using it. If you confirm that, my suggestion is to exclude the support on your build.gradle:

	implementation("me.dm7.barcodescanner:zxing:1.9.13") {
		exclude group: "com.android.support", module: "support-v4"
	}

So, the plugin report is ok, maybe could be clearer. I created two issues to give more useful information:

I will transform this issue into a discussion.
Thanks

1 reply

carstenhag Dec 14, 2020
Author

Thanks for creating the issues :)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Indicate which dependency included a transitive lib with legacy support usage #16

{{title}}

Replies: 4 comments 1 reply

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

Select a reply

Indicate which dependency included a transitive lib with legacy support usage #16

carstenhag Dec 10, 2020

Replies: 4 comments · 1 reply

carstenhag Dec 11, 2020 Author

maxirosson Dec 14, 2020 Maintainer

carstenhag Dec 14, 2020 Author

maxirosson Dec 14, 2020 Maintainer

carstenhag Dec 14, 2020 Author

carstenhag
Dec 10, 2020

Replies: 4 comments 1 reply

carstenhag
Dec 11, 2020
Author

maxirosson
Dec 14, 2020
Maintainer

carstenhag
Dec 14, 2020
Author

maxirosson
Dec 14, 2020
Maintainer

carstenhag Dec 14, 2020
Author