Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated function. #1136

Merged
merged 1 commit into from
Nov 1, 2016
Merged

Update deprecated function. #1136

merged 1 commit into from
Nov 1, 2016

Conversation

skoudoro
Copy link
Member

get_header() / get_affine() method is deprecated from nibabel 2.1, we use header / affine property instead

…recated from nibabel 2.1, we use header / affine property instead
@arokem
Copy link
Contributor

arokem commented Oct 29, 2016

Thanks for doing this! I just noticed this in running tests on my machine as well. Let's see how Travis takes to it.

@codecov-io
Copy link

codecov-io commented Oct 29, 2016

Current coverage is 84.60% (diff: 100%)

Merging #1136 into master will not change coverage

@@             master      #1136   diff @@
==========================================
  Files           219        219          
  Lines         24864      24864          
  Methods           0          0          
  Messages          0          0          
  Branches       2513       2513          
==========================================
  Hits          21036      21036          
  Misses         3199       3199          
  Partials        629        629          

Powered by Codecov. Last update 9bbb5a4...f0db93b

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.134% when pulling f0db93b on skoudoro:example_update into 9bbb5a4 on nipy:master.

@arokem
Copy link
Contributor

arokem commented Oct 29, 2016

Great! Seems to work fine, even with relatively elderly nibable: https://travis-ci.org/nipy/dipy/jobs/171644798

I am +1 here, but I will let others take a look as well (and merge in a few days if no one has anything to say about it).

@Garyfallidis
Copy link
Contributor

👍 from me too. Thank you @skoudoro :)

@arokem arokem merged commit e804e68 into dipy:master Nov 1, 2016
@skoudoro skoudoro deleted the example_update branch November 3, 2016 14:26
@skoudoro
Copy link
Member Author

skoudoro commented Nov 3, 2016

no problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants