Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IVIM VarPro implementation throws infeasible 'x0' #1828

Open
ShreyasFadnavis opened this issue May 7, 2019 · 10 comments
Open

IVIM VarPro implementation throws infeasible 'x0' #1828

ShreyasFadnavis opened this issue May 7, 2019 · 10 comments
Assignees

Comments

@ShreyasFadnavis
Copy link
Member

ShreyasFadnavis commented May 7, 2019

Description

This bug occurs rarely when the number of iterations for Differential Evolution is low.

Will follow-up with a PR with:

  • Default
  • Warning when user reduces the maxiter below a certain value.

#1826 will also help fix some of these issues.

Way to reproduce

-- Cannot be reproduced with a fixed recipe.

@ShreyasFadnavis
Copy link
Member Author

@Garyfallidis @arokem Please feel free to let me know any other approach you have in mind. Another alternative I have is to switch to LM implementation is the solution is infeasible (may result in a linear fit though). I think, after Cythonizing the implementation, this bug would go away anyways!

@ShreyasFadnavis ShreyasFadnavis self-assigned this May 8, 2019
@ShreyasFadnavis ShreyasFadnavis added this to the 1.0 milestone May 8, 2019
@ShreyasFadnavis ShreyasFadnavis changed the title Bug: IVIM VarPro implementation throws infeasible 'x0' ENH: IVIM VarPro implementation throws infeasible 'x0' May 8, 2019
@ShreyasFadnavis ShreyasFadnavis changed the title ENH: IVIM VarPro implementation throws infeasible 'x0' IVIM VarPro implementation throws infeasible 'x0' May 8, 2019
@ShreyasFadnavis
Copy link
Member Author

#1839 fixes this. Closing!

@yinting527
Copy link

@ShreyasFadnavis Hello, I'm trying out ivim varpro reconstruction using dipy, and getting error message " x0 is infeasible." while not setting the bounds, and "Inconsistent shapes between bounds and x0." after setting bounds. the 'trr' method won't give this error. May I ask how should I solve this? Thanks!

@ShreyasFadnavis
Copy link
Member Author

ShreyasFadnavis commented Oct 28, 2019

@ShreyasFadnavis Hello, I'm trying out ivim varpro reconstruction using dipy, and getting error message " x0 is infeasible." while not setting the bounds, and "Inconsistent shapes between bounds and x0." after setting bounds. the 'trr' method won't give this error. May I ask how should I solve this? Thanks!

Hi @xxhdd ! Thank you for reaching out and reporting this. As for the bounds, there are certain things to keep in mind when using VarPro as it's a slightly different optimizer as compared to trr. Can I take a quick look at your code? You can mail it to me on shreyasfadnavis@gmail.com

On a side note, are you using a mask?
I am also making a new update for the code with a speeded up version and will handle bounds better!

@arokem
Copy link
Contributor

arokem commented Oct 28, 2019

@xxhdd : You can post the code here, so that people other than @ShreyasFadnavis can see it, and so that we don't have to wonder what happened a year down the line, when we're dealing with any other issues.

@ShreyasFadnavis
Copy link
Member Author

ShreyasFadnavis commented Oct 30, 2019

PR #1993 should fix this. The issue was that @xxhdd is working with animal data and not the brain. the x0 is not feasible error has been handled by reusing the same procedure used in trr.

@skoudoro skoudoro modified the milestones: 1.0, 1.2 Jan 3, 2020
@skoudoro
Copy link
Member

skoudoro commented Jan 8, 2020

Hi @ShreyasFadnavis,

What is the status of this issue? I do not find the related PR, Can you point it to me?

Thank you

@ShreyasFadnavis
Copy link
Member Author

Hi @skoudoro ! This issue has been resolved for @xxhdd . However I do intend to make a new PR with an updated version of this... I will also add the error handling withing that 👍

@skoudoro
Copy link
Member

skoudoro commented Jan 9, 2020

ok, so I let this issue open and look forward to seeing your PR @ShreyasFadnavis!

@skoudoro skoudoro modified the milestones: 1.2, 1.3 Sep 2, 2020
@skoudoro skoudoro modified the milestones: 1.3, 1.4 Oct 15, 2020
@skoudoro skoudoro removed this from the 1.4 milestone Mar 15, 2021
@seanyang9527
Copy link

Hi, I've encountered the same error message. Despite spending days going through the PRs, I couldn't find a solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants