Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fig_kwargs #2168

Merged
merged 1 commit into from
Jul 23, 2020
Merged

add fig_kwargs #2168

merged 1 commit into from
Jul 23, 2020

Conversation

Borda
Copy link
Contributor

@Borda Borda commented May 15, 2020

I found quite convenient to add extra figure arguments

@pep8speaks
Copy link

pep8speaks commented May 15, 2020

Hello @Borda, Thank you for updating !

Line 52:81: E501 line too long (93 > 80 characters)

Comment last updated at 2020-07-22 17:45:09 UTC

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #2168 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2168   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files         251      251           
  Lines       32449    32449           
  Branches     3408     3408           
=======================================
  Hits        29651    29651           
  Misses       2057     2057           
  Partials      741      741           
Impacted Files Coverage Δ
dipy/viz/regtools.py 31.49% <33.33%> (ø)

@skoudoro
Copy link
Member

Thank you for this @Borda!

Looks fine to me. Can you just fix the pep8 above and it is ready to be merged.
Thank you

@Borda Borda marked this pull request as ready for review May 18, 2020 16:14
@Borda
Copy link
Contributor Author

Borda commented May 18, 2020

Looks fine to me. Can you just fix the pep8 above and it is ready to be merged.

it looks like some unrelated issue...
E ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1076)

@skoudoro
Copy link
Member

Yes, I saw that, there is an issue for it (#2172)

@Borda
Copy link
Contributor Author

Borda commented May 18, 2020

Yes, I saw that, there is an issue for it (#2172)

so I will wait till it is resolved... :]

@Borda
Copy link
Contributor Author

Borda commented Jun 10, 2020

@skoudoro rebased on actual master 🦝

@skoudoro
Copy link
Member

Master has been fixed @Borda, you can rebase, and finalize your PR. Sorry for the delay

@Borda
Copy link
Contributor Author

Borda commented Jul 22, 2020

@skoudoro done :]

@skoudoro skoudoro added this to the 1.2 milestone Jul 22, 2020
@skoudoro skoudoro merged commit 4a5b3b6 into dipy:master Jul 23, 2020
@skoudoro
Copy link
Member

Thank you @Borda!

@Borda Borda deleted the fig_kwargs branch July 23, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants