[DOC] Update SH basis documentation #2176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! thank you for doing this @CHrlS98. Let's see if there are any comments otherwise, I will merge this when Travis finishes. |
Codecov Report
@@ Coverage Diff @@
## master #2176 +/- ##
=======================================
Coverage 91.27% 91.28%
=======================================
Files 251 251
Lines 32421 32421
Branches 3420 3420
=======================================
+ Hits 29593 29595 +2
Misses 2085 2085
+ Partials 743 741 -2
|
GuillaumeTh
approved these changes
May 29, 2020
There was a problem hiding this comment.
I recheck all the maths and that looks good to me. @skoudoro Something to do about the CI ?
|
Thank you for your feedback @GuillaumeTh. merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm doing a summer internship with @mdesco. I'm working on full spherical harmonic basis (including odd and even order terms) for reconstructing asymmetric spherical functions (coming soon in other pull request). There were inconsistencies between implementation of functions
real_sym_sh_mrtrixandreal_sym_sh_basisfrom moduledipy.reconst.shmand documentation of theory on spherical harmonic bases. I fixed the doc for it to agree with the implementation.