Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] update Azure OSX CI + remove Azure Linux CI's #2258

Merged
merged 1 commit into from
Oct 17, 2020

Conversation

skoudoro
Copy link
Member

  • Update the version of our macOS virtual machine. from macOS-10.14 to macOS-latest. This should fix our SSL issue with python
  • Remove all Linux matrix on Azure Pipeline. It was experimental. The goal was to see if we can have only one tool to maintain, stop Travis, and switch completely to Azure Pipeline. After this long experimental experience, I think we should keep both, Azure pipeline and Travis. So I just removed the duplicated Linux matrices to speed up a bit the building time of our PR

@skoudoro skoudoro added this to the 1.3 milestone Oct 17, 2020
@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #2258 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2258   +/-   ##
=======================================
  Coverage   91.44%   91.45%           
=======================================
  Files         254      254           
  Lines       33574    33574           
  Branches     3532     3532           
=======================================
+ Hits        30702    30704    +2     
  Misses       2083     2083           
+ Partials      789      787    -2     
Impacted Files Coverage Δ
dipy/viz/app.py 77.47% <0.00%> (+0.49%) ⬆️

@arokem
Copy link
Contributor

arokem commented Oct 17, 2020

Looks like maybe there are some issue install scs and ecos on OSX/Python 3.8:

https://dev.azure.com/dipy/dipy/_build/results?buildId=730&view=logs&j=b8285961-b5bb-5480-5e45-605bdb8d8550&t=0beb2fcb-e8fb-5580-4398-e341de8e0316&l=264

I couldn't find any other reports of this issue.

@skoudoro
Copy link
Member Author

Strange... it seems that it works here. I will restart the CI to be sure.

@arokem
Copy link
Contributor

arokem commented Oct 17, 2020

Oh yeah! 🤞 that it's just a glitch.

@skoudoro
Copy link
Member Author

it was a glitch!

it is ready to go! 🎉

@arokem arokem merged commit 749f5db into dipy:master Oct 17, 2020
@skoudoro skoudoro deleted the fix-ci branch October 17, 2020 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants