Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI denoise patch_size error #2559

Closed
slieped opened this issue Mar 9, 2022 · 1 comment · Fixed by #2631
Closed

CLI denoise patch_size error #2559

slieped opened this issue Mar 9, 2022 · 1 comment · Fixed by #2631

Comments

@slieped
Copy link

slieped commented Mar 9, 2022

Description

To update CLI documentation.

When doing a CLI call for dipy denoise methods, if patch size is not provided with 3 values, the cmd return an ValueError.
This differ from what is written in the documentation (https://dipy.org/documentation/1.4.1./interfaces/denoise_flow/#denoising-using-marcenko-pastur-pca)

Info

DIPY version: 1.4.1

Way to reproduce

CMD call that return error
dipy_denoise_mppca sub-002S6652_ses-m12_dwi.nii --out_dir dwipreproc1.0.0 --patch_radius 3

CMD call that works
dipy_denoise_mppca sub-002S6652_ses-m12_dwi.nii --out_dir dwipreproc1.0.0 --patch_radius 3 3 3

Solution

Update CLI documentation. Both dipy_denoise_mppca && dipy_denoise_nlmeans

@skoudoro
Copy link
Member

skoudoro commented Mar 9, 2022

Hi @slieped,

Thank you for the feedback.

This is a bug since it should work with both cases. we will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants