[Question] dipy/denoise/gibbs.py

[tashrifbillah]

dipy/dipy/denoise/gibbs.py

Lines 322 to 324 in 77afd60

	# Copy data if not inplace
	if not inplace:
	vol = vol.copy()

The copied volume is overwritten below anyway:

dipy/dipy/denoise/gibbs.py

Lines 327 to 335 in 77afd60

	if nd == 2:
	vol[:, :] = _gibbs_removal_2d(vol, n_points=n_points, G0=G0, G1=G1)
	else:
	pool = Pool(num_processes)
	partial_func = partial(
	_gibbs_removal_2d, n_points=n_points, G0=G0, G1=G1
	)
	vol[:, :, :] = pool.map(partial_func, vol)

So what is the point of using inplace parameter?

[skoudoro]

Good catch, I think this parameter is useless. Either we need to remove the parameter or make inplace=False work. Low priority.

Feel free to fix this issue @tashrifbillah !

[skoudoro]

After playing with the code, I think I made a mistake. The inplace argument works as expected and avoid you to modify the input volume.

So closing the issue and the PR